Difference between revisions of "Using the Github UI to Make Pull Requests"
From Joomla! Documentation
m (Needs updating for the PR process on gitHub) |
|||
(13 intermediate revisions by 5 users not shown) | |||
Line 1: | Line 1: | ||
Github has a simple web interface that makes it very easy to propose a simple change to code. You do not need to install any software or do anything beside register for a git hub account. | Github has a simple web interface that makes it very easy to propose a simple change to code. You do not need to install any software or do anything beside register for a git hub account. | ||
− | + | These suggestions apply to forks of both joomla-cms and joomla-platform, although the screenshots are for joomla-cms. | |
− | |||
− | |||
− | |||
− | |||
− | |||
− | == | + | == Identify a change you want to make. == |
− | + | [[File:easygithub1.png|frame|none]] | |
− | |||
− | |||
− | |||
− | |||
− | |||
− | |||
− | |||
− | [[File: | ||
+ | == Find the file you want to modify on Github== | ||
+ | [[File:easygithub2.png|frame|none]] | ||
− | [[Category: Bug Squad]] [[Category: Development]] | + | Note if you want to make the change to 2.5 the branch should be 2.5.x, and if you want to make the change to 3.x then make the change to the staging branch. You should never PR to the master branch. |
+ | |||
+ | == Click Edit to open the file == | ||
+ | [[File:easygithub4.png|frame|none]] | ||
+ | |||
+ | == Make your change== | ||
+ | [[File:easygithub5.png|frame|none]] | ||
+ | |||
+ | == Scroll down and click the Propose file change button (add a note if you want).== | ||
+ | [[File:easygithub6.png|frame|none]] | ||
+ | |||
+ | == Fill in any additional information in the pull request including references to an existing issue or PR.== | ||
+ | [[File:easygithub7.png|frame|none]] | ||
+ | |||
+ | '''NOTE: For pull requests for joomla-cms, the 'base branch' on the left must be set to staging (not master). | ||
+ | ''' | ||
+ | |||
+ | '''NOTE: Joomla Code has now been deprecated. You do NOT need a JoomlaCode link in your pull request anymore. | ||
+ | ''' | ||
+ | |||
+ | == Click Send pull request.== | ||
+ | [[File:easygithub8.png|frame|none]] | ||
+ | |||
+ | <noinclude> | ||
+ | [[Category:Bug Squad]] | ||
+ | [[Category:Development]] | ||
+ | [[Category:GitHub]] | ||
+ | [[Category:Needs updating]] | ||
+ | </noinclude> |
Revision as of 13:08, 16 May 2015
Github has a simple web interface that makes it very easy to propose a simple change to code. You do not need to install any software or do anything beside register for a git hub account.
These suggestions apply to forks of both joomla-cms and joomla-platform, although the screenshots are for joomla-cms.
Identify a change you want to make.[edit]
Find the file you want to modify on Github[edit]
Note if you want to make the change to 2.5 the branch should be 2.5.x, and if you want to make the change to 3.x then make the change to the staging branch. You should never PR to the master branch.
Click Edit to open the file[edit]
Make your change[edit]
Scroll down and click the Propose file change button (add a note if you want).[edit]
Fill in any additional information in the pull request including references to an existing issue or PR.[edit]
NOTE: For pull requests for joomla-cms, the 'base branch' on the left must be set to staging (not master).
NOTE: Joomla Code has now been deprecated. You do NOT need a JoomlaCode link in your pull request anymore.